[FFmpeg-devel] [PATCH] Add --enable-rpath option to add -Wl, -rpath to pkg-config files.

[Reimar Döffinger]

On Sun, Nov 10, 2013 at 10:45:26PM +0100, Lukasz M wrote:
> On 10 November 2013 09:18, Reimar Döffinger <Reimar.Doeffinger at gmx.de>wrote:
> 
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > ---
> >  configure | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 2db047a..f84e8a8 100755
> > --- a/configure
> > +++ b/configure
> > @@ -87,6 +87,8 @@ Standard options:
> >    --shlibdir=DIR           install shared libs in DIR [PREFIX/lib]
> >    --incdir=DIR             install includes in DIR [PREFIX/include]
> >    --mandir=DIR             install man page in DIR [PREFIX/share/man]
> > +  --enable-rpath           use rpath to allow installing libraries in
> > paths
> > +                           not part of the dynamic linker search path
> >
> >  Licensing options:
> >    --enable-gpl             allow use of GPL code, the resulting libs
> > @@ -1609,6 +1611,7 @@ CMDLINE_SELECT="
> >      logging
> >      lto
> >      optimizations
> > +    rpath
> >      stripping
> >  "
> >
> > @@ -4458,6 +4461,7 @@ enabled extra_warnings && check_cflags -Winline
> >  # add some linker flags
> >  check_ldflags -Wl,--warn-common
> >  check_ldflags
> > -Wl,-rpath-link=libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample
> > +enabled rpath && add_ldflags -Wl,-rpath=$libdir
> >
> 
> maybe you can also add && enabled shared to add rpath only when linking
> with shared libs.

I don't particularly like adding complexity, which in addition
just ignores what the user specified.
If anything I'd say it should be an error to use the flag without
--enable-shared.