[FFmpeg-devel] [PATCH]Warn the user when trying to mux ac3 in mpeg-1 stream

[Michael Niedermayer]

On Thu, Nov 21, 2013 at 12:22:15PM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> WMP (and mplayer -demuxer mpegps) refuse to read ac3 in MPEG-1 streams, both 
> work fine with -f vob and -f dvd.
> 
> Trying to address ticket #1720
> 
> Please comment, Carl Eugen

>  ffmpeg.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> e40c7b3254925d9e7c965abc339fd06f5abec6fe  patchmpegac3.diff
> diff --git a/ffmpeg.c b/ffmpeg.c
> index 5eb395f..74c0964 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -2189,6 +2189,12 @@ static int transcode_init(void)
>                  if (codec->codec_type == AVMEDIA_TYPE_AUDIO || codec->codec_type == AVMEDIA_TYPE_VIDEO)
>                      ost->st->disposition = AV_DISPOSITION_DEFAULT;
>          }
> +        if (!strcmp(oc->oformat->name, "mpeg") &&
> +            ( ost->stream_copy && icodec->codec_id == AV_CODEC_ID_AC3 ||
> +             !ost->stream_copy && ost->enc && !strcmp(ost->enc->name, "ac3")))
> +            av_log(NULL, AV_LOG_WARNING,
> +                   "ac3 in MPEG-1 system streams is not widely supported, "
> +                   "consider using -f vob or -f dvd to force MPEG-2 program stream.\n");

shouldnt this be printed by the mpeg muxer instead of just 1
application  (ffmpeg) ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131121/3d55e574/attachment.asc>