[FFmpeg-devel] [PATCH] configure: define CONFIG_THIS_YEAR at the configure level

Timothy Gu timothygu99 at gmail.com
Tue Nov 26 01:00:28 CET 2013


On Mon, Nov 25, 2013 at 3:59 PM, Timothy Gu <timothygu99 at gmail.com> wrote:
> On Mon, Nov 25, 2013 at 2:33 PM, Stefano Sabatini <stefasab at gmail.com> wrote:
>> The macro can be shared between configure script and cmdutils.c.
>> ---
>>  cmdutils.c | 2 +-
>>  configure  | 1 +
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/cmdutils.c b/cmdutils.c
>> index c7e8acf..ebb747a 100644
>> --- a/cmdutils.c
>> +++ b/cmdutils.c
>> @@ -69,7 +69,7 @@ struct SwsContext *sws_opts;
>>  AVDictionary *swr_opts;
>>  AVDictionary *format_opts, *codec_opts, *resample_opts;
>>
>> -const int this_year = 2013;
>> +const int this_year = CONFIG_THIS_YEAR;

Also, why don't we just remove this_year and use CONFIG_THIS_YEAR throughout?

>>
>>  static FILE *report_file;
>>
>> diff --git a/configure b/configure
>> index 6b0375b..1bf05cb 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4910,6 +4910,7 @@ cat > $TMPH <<EOF
>>  #define FFMPEG_CONFIG_H
>>  #define FFMPEG_CONFIGURATION "$(c_escape $FFMPEG_CONFIGURATION)"
>>  #define FFMPEG_LICENSE "$(c_escape $license)"
>> +#define CONFIG_THIS_YEAR 2013
>>  #define FFMPEG_DATADIR "$(eval c_escape $datadir)"
>>  #define AVCONV_DATADIR "$(eval c_escape $datadir)"
>>  #define CC_IDENT "$(c_escape ${cc_ident:-Unknown compiler})"
>
> LGTM.
>
> Timothy


More information about the ffmpeg-devel mailing list