[FFmpeg-devel] [PATCH] Add Windows resource file support for shared libraries

[Timothy Gu]

On Nov 25, 2013 5:15 PM, "James Almer" <jamrial at gmail.com> wrote:
>
> On 25/11/13 9:26 PM, Timothy Gu wrote:
> > On Mon, Nov 25, 2013 at 2:06 PM, James Almer <jamrial at gmail.com> wrote:
> >> On 25/11/13 6:59 PM, Timothy Gu wrote:
> >>> Based on patch by: James Almer <jamrial at gmail.com>
> >>>
> >>> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
> >>> ---
> >>>
> >>> Sorry if the older patch in the thread doesn't apply.
> >>>
> >>> ---
> >>>
> >>> Differences from James's version [1]:
> >>> * Now generate the .rc files from configure (like we do with
pkg-config files).
> >>
> >> I'm not sure about this. They don't get installed, and having one .rc
file per
> >> folder won't bother anyone, whereas the big generator function in
configure will
> >> be a small nuisance with merges from libav.
> >> x264 and mplayer ship with the .rc files in the source tree and don't
generate them
> >> either.
> >
> > OK. How about adding this function as a standalone tool to tool/?
>
> Why do you want the .rc files to be generated at configure/compile time?
> Every library specific value that is not hardcoded can be taken from C
headers unlike
> with pkg-config files (Which is why they get generated).
> And regarding a standalone script, we currently don't include any scripts
in configure,
> so i think it's better to have this function in configure as well if it
comes to it.
>
> Does anyone else have an opinion about all this?

You misunderstood me. I meant to have rc files in the tree while moving
this to a standalone script and use that to update/add .rc files.

Timothy