[FFmpeg-devel] [PATCH] configure: add #include "version.h" to config.h

[Michael Niedermayer]

On Wed, Nov 27, 2013 at 04:27:41PM -0800, Timothy Gu wrote:
> On Nov 27, 2013 4:22 PM, "Michael Niedermayer" <michaelni at gmx.at> wrote:
> >
> > On Wed, Nov 27, 2013 at 04:13:44PM -0800, Timothy Gu wrote:
> > > On Nov 27, 2013 3:23 PM, "Michael Niedermayer" <michaelni at gmx.at> wrote:
> > > >
> > > > On Wed, Nov 27, 2013 at 08:10:52PM -0300, James Almer wrote:
> > > > > On 27/11/13 7:45 PM, Michael Niedermayer wrote:
> > > > > > On Tue, Nov 26, 2013 at 02:43:18PM -0800, Timothy Gu wrote:
> > > > > >> Avoid clash with version.h of the libraries.
> > > > > >>
> > > > > >> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
> > > > > >> ---
> > > > > >>  cmdutils.c | 1 -
> > > > > >>  configure  | 1 +
> > > > > >>  ffprobe.c  | 1 -
> > > > > >>  3 files changed, 1 insertion(+), 2 deletions(-)
> > > > > >
> > > > > > applied
> > > > > >
> > > > > > thanks
> > > > >
> > > > > Bad secondary effect i just noticed: Every time version.h is changed
> > > > > (git pull for example), anything that includes config.h will be
> > > > > recompiled. And that means pretty much every single file in the
> tree.
> > > > >
> > > > > This should probably be reverted. Then we can think on an
> alternative
> > > > > solution.
> > > >
> > > > agree, reverted :(
> > > >
> > > > maybe we could add a ffmpeg_version.h, and include that where needed
> > >
> > > Do you mean changing the file name to ffmpeg_version.h? That seems like
> the
> > > best solution now.
> >
> > that or a ffmpeg_version.h which #inlcudes version.h or the other
> > way around
> 
> I'd then prefer direct renaming. Why add a dummy header?

i was just thinking that something might use it, a script or some
application that contains a copy of ffmpeg.
but these are just hypothetical cases, ive no examples

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131128/27d1d24e/attachment.asc>