[FFmpeg-devel] [PATCH 5/5] build: rename version.h to libavutil/ffversion.h

[Timothy Gu]

On Thu, Nov 28, 2013 at 7:07 PM, James Almer <jamrial at gmail.com> wrote:
> On 29/11/13 12:04 AM, James Almer wrote:
>> On 28/11/13 11:38 PM, Timothy Gu wrote:
>>> On Nov 28, 2013 6:25 PM, "James Almer" <jamrial at gmail.com> wrote:
>>>>
>>>> On 28/11/13 10:00 PM, Timothy Gu wrote:
>>>>> Also the libavutil/ffversion.h will be installed.
>>>>>
>>>>> Rationale:
>>>>> * Applications might want to know FFmpeg's version besides the
>>> individual
>>>>>   libraries'.
>>>>> * Avoids file name clash between FFmpeg's ./version.h and
>>> lib*/version.h when
>>>>>   a library source file includes both and is compiled on an out-of-tree
>>> build.
>>>>>
>>>>
>>>> Missing minor bump for lavu.
>>>
>>> Do I need to add it to APIChanges?
>>>
>> It's a new installed header, so I'd say yes.
>>
>
> I forgot, since it's installed, it needs to have preprocessor guards, same as
> avconfig.h

Remarks all fixed.

Note that these 2 patches depend on "make version.sh independent of
version.h file name", "add license header", and "usage comment"
patches.

Timothy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-version.sh-add-preprocessing-guards.patch
Type: text/x-patch
Size: 1052 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131129/b4e71e7d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-build-rename-version.h-to-libavutil-ffversion.h.patch
Type: text/x-patch
Size: 4186 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131129/b4e71e7d/attachment-0001.bin>