[FFmpeg-devel] [PATCH] Fix compilation with nasm.

[Dave Yeo]

On 10/07/13 07:04 pm, Ronald S. Bultje wrote:
> Hi,
>
> On Mon, Oct 7, 2013 at 9:02 PM, Michael Niedermayer<michaelni at gmx.at>wrote:
>
>> On Mon, Oct 07, 2013 at 08:36:22PM -0400, Ronald S. Bultje wrote:
>>> Hi,
>>>
>>> On Mon, Oct 7, 2013 at 8:33 PM, Michael Niedermayer<michaelni at gmx.at
>>> wrote:
>>>
>>>> On Tue, Oct 08, 2013 at 02:24:33AM +0200, Michael Niedermayer wrote:
>>>>> On Mon, Oct 07, 2013 at 08:06:47PM -0400, Ronald S. Bultje wrote:
>>>>>> From: "Ronald S. Bultje"<rsbultje at gmail.com>
>>>>>>
>>>>>> ---
>>>>>>   libavcodec/x86/fft.asm              | 3 +--
>>>>>>   libavcodec/x86/vp9dsp.asm           | 6 +++---
>>>>>>   libswresample/x86/audio_convert.asm | 3 +--
>>>>>>   libswresample/x86/rematrix.asm      | 3 +--
>>>>>>   4 files changed, 6 insertions(+), 9 deletions(-)
>>>>>
>>>>> applied
>>>>
>>>> hmm, seems only the vp9dsp change is neede for nasm so i applied only
>>>> that
>>>
>>>
>>> It fails for me, saying that alignment was specified twice with different
>>> values, and then aborts compilation. It's actually worse, it leaves
>> behind
>>> an empty object file, thus if you type "make" again it thinks it
>> succeeded,
>>> but then linking fails.
>>>
>>> Maybe that only happens on x86-64 or mac, not on other platforms?
>>
>> for me it works on x86-64 with
>> NASM version 2.09.10 compiled on Oct 17 2011
>> on linux
>>
>> but if the other hunks are needed too then they should be applied too
>>
>
> Fails on:
> NASM version 2.10 compiled on Apr 19 2012
> Mac x86-64.
>
> Can anyone else reproduce success/failure on nasm-2.10?
>

Patch fixes compilation on OS/2 with nasm 2.10.09, compiled locally with 
straight configure && make with gcc4.4.6. Previously linking failed with 
unresolved symbols.
Dave