[FFmpeg-devel] [PATCH 3/3] doc/developer: Add an item to the policy about maintainership
michaelni at gmx.at
Sat Oct 12 00:00:45 CEST 2013
This is intended to solve the issue where developers and or maintainers
reply with LGTM somewhere in the middle of a long thread maybe conditionally
on other changes or just on some hunks that are part of a patch that doesnt
apply cleanly and then run away without applying the change and no one else
being certain what exactly they meant or just forget once the conditions are
met that someone had previously conditionally approved the patch.
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
doc/developer.texi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/doc/developer.texi b/doc/developer.texi
index 077c67f..0dac040 100644
@@ -392,6 +392,15 @@ MAINTAINERS file. If something that you want to maintain is missing add it with
your name after it.
If at some point you no longer want to maintain some code then please help
finding a new maintainer and also dont forget updating the MAINTAINERS file.
+ at item
+For code that you maintain, make sure that regressions get fixed and patches
+get reviewed and applied.
+Do not just reply to patches that fall under your maintainership with LGTM after
+testing and review, but rather submit a pull request or push the patches.
+If one of your patches was approved but noone applies it within 24h send a pull
+request to michaelni at gmx dot at with a reference to the approval.
+In pull requests be precisse what exact branch/commits should be pulled.
We think our rules are not too hard. If you have comments, contact us.
More information about the ffmpeg-devel