[FFmpeg-devel] [PATCH] cinepak encoder [reply to an old post from April]

Michael Niedermayer michaelni at gmx.at
Sat Oct 19 17:23:52 CEST 2013


On Mon, Sep 23, 2013 at 11:43:55AM +0000, u-owvm at aetey.se wrote:
> On Fri Apr 5 14:52:30 CEST 2013 Paul B Mahol wrote:
> > Quick and dirty adaptation of patch linked on multimedia.cx
> > (I fixed some ugly style issues)
> > 
> > I added experimental flag as i get some artifacts with single file i tried
> > to transcode.
> Hello Paul,
> (My earlier letter to you was probably eaten by spam filters?)
> The online patch file around the 5th of April was unfortunately from a
> badly broken version which explains the artifacts in your test.
> The fixed version is online since 2013-04-28 at the same url
>  http://www.aetey.se/dl/cinepak-encoder-ffmpeg.patch

can you send a proper git patch please, especially the author
field is needed if you want this to be in ffmpeg

> The encoded streams play well with the open source decoder but are not
> compatible with the vintage/proprietary ones (the latter probably expect
> matching chunk types on key- vs non-keyframes which the encoder does
> not care to arrange - should be easy to fix but nobody tried).

If it does not generate files that can be played by the "official"
decoder then the encoder should be marked as experimental so users
dont mistakely use it without understanding that its output is not
going to play on all cinepak decoders

Also you might want to add yourself to the MAINTAINERs file for this
encoder, assuming you want to maintain it



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131019/bb6c0f6c/attachment.asc>

More information about the ffmpeg-devel mailing list