[FFmpeg-devel] [PATCH 2/4] base64-test: Remove posibility of returning restrcted exit codes

Michael Niedermayer michaelni at gmx.at
Wed Oct 23 00:07:20 CEST 2013


On Tue, Oct 22, 2013 at 09:37:54PM +0100, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  libavutil/base64.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavutil/base64.c b/libavutil/base64.c
> index 87e2dfd..348690d 100644
> --- a/libavutil/base64.c
> +++ b/libavutil/base64.c
> @@ -270,7 +270,10 @@ int main(int argc, char ** argv)
>          }
>      }
>  
> -    return error_count;
> +    if (error_count)
> +        printf("Error Count: %d.\n", error_count);

i wonder if all the error printfs in the selftest code should be
fprintf(stderr
but thats unrelated to the patch


> +
> +    return !!error_count;

patch LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131023/890a023b/attachment.asc>


More information about the ffmpeg-devel mailing list