[FFmpeg-devel] [PATCH] avcodec/get_bits: consider bit_size of 0 an error

Paul B Mahol onemda at gmail.com
Mon Oct 28 18:04:38 CET 2013

On 10/28/13, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
> On Mon, Oct 28, 2013 at 04:52:27PM +0000, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> Could you add the reason for this change to the commit message?
> In theory being able to use 0 might work as an optimization in
> some cases, so I don't think supporting it is as nonsense as it
> might seem.

What kind of optimization?

If return value is never checked and bit_size is negative number next
get_bits will happily crash.

More information about the ffmpeg-devel mailing list