[FFmpeg-devel] iSight camera support

Vadim Kalinsky vadim at kalinsky.ru
Wed Oct 30 03:53:11 CET 2013

On 2013-10-29, at 7:26 PM, Lukasz M <lukasz.m.luki at gmail.com> wrote:

Thanks for your comments, Lukasz

> On 28 October 2013 21:21, Vadim Kalinsky <vadim at kalinsky.ru> wrote:
> I'm not Mac developer, but iOS and also don't know QTKit, but have few
> remarsk after quick look
> In general you should fix formatting and styles. It is messy.

I tried to keep Objective-C "camel case" style in Objective-C code.

> It would be easier to review when you squash patches. Last one adds new
> line only. :)

I created the patch from github pull request, seems like this feature doesn't work well there.

New patch attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iSight_support_cummulative.patch
Type: application/octet-stream
Size: 12605 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131029/2e1725d9/attachment.obj>
-------------- next part --------------

Vadim Kalinsky

vadim at kalinsky.ru            **            http://kalinsky.ru

More information about the ffmpeg-devel mailing list