[FFmpeg-devel] [PATCH]opencl: compile kernels separately

Wei Gao highgod0401 at gmail.com
Wed Oct 30 04:07:20 CET 2013


2013/10/30 Lenny Wang <lenny at multicorewareinc.com>

> Attached new patch after 2nd review.
>
> On Tue, Oct 29, 2013 at 3:24 PM, Lenny Wang <lenny at multicorewareinc.com>
> wrote:
> > Attached new patch has been cleaned up and modified based on previous
> > reviewer's comments.  Any comments or questions please just let me
> > know.
> >
> > On Tue, Oct 29, 2013 at 4:19 AM, Thilo Borgmann <thilo.borgmann at mail.de>
> wrote:
> >> Am 29.10.13 07:59, schrieb Lenny Wang:
> >>> Currently opencl kernels in ffmpeg are compiled altogether at
> >>> initialization stage, most of related data structures are maintained
> within
> >>> the opencl framework of ffmpeg.  This is very cumbersome to use and is
> not
> >>> efficient.  This patch uses distributed opencl programs/kernels for
> each
> >>> filter (or potentially any other component that uses opencl), allowing
> >>> kernels to be compiled separately at each component's initialization
> stage.
> >>>
> >>> Tests have been conducted successfully on mainstream Nvidia/AMD/Intel
> >>> platforms with "-vf deshake=opencl=1,unsharp=opencl=1".
> >>
> >> Your patch contains trailing whitespaces, a lot of unnecessary and
> unrelated
> >> changes. Please clean it up and resubmit it.
> >>
> >> -Thilo
>

Hi, I reviewed the patch, and still has some bugs on code styles.

I correct all bugs which I have found and make a patch, is it OK for you?

Thanks

Best regards

> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavu-opencl-compile-opencl-kernels-separately.patch
Type: application/octet-stream
Size: 22117 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131030/43132394/attachment.obj>


More information about the ffmpeg-devel mailing list