[FFmpeg-devel] [PATCH 3/3] doc/encoders: Improve libvo-aacenc doc

[Timothy Gu]

On Mon, Sep 9, 2013 at 1:14 AM, Stefano Sabatini <stefasab at gmail.com> wrote:
> On date Sunday 2013-09-08 17:02:06 -0700, Timothy Gu encoded:
>> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
>> ---
>>  doc/encoders.texi | 16 +++++++++++++---
>>  1 file changed, 13 insertions(+), 3 deletions(-)
>>
>> diff --git a/doc/encoders.texi b/doc/encoders.texi
>> index 3ef8f6b..668ffad 100644
>> --- a/doc/encoders.texi
>> +++ b/doc/encoders.texi
>> @@ -652,16 +652,26 @@ Requires the presence of the libvo-aacenc headers and library during
>>  configuration. You need to explicitly configure the build with
>>  @code{--enable-libvo-aacenc --enable-version3}.
>>
>
>> +This encoder is considered to be worse than the
>> + at ref{aacenc,,native experimental FFmpeg AAC encoder}, according
>> +to several sources:
>> +
>> + at itemize
>> + at item
>> + at url{http://ffmpeg.org/pipermail/ffmpeg-devel/2013-June/144589.html}
>> + at item
>> + at url{http://d.hatena.ne.jp/kamedo2/20120729/1343545890}
>> + at end itemize
>> +
>
> I'd better keep off links to external benchmarks in reference
> documentation, especially when the linked page is in Japanese.

Fixed

> Also
> native and library code may change in the future (that's the kind of
> comparison which really belongs to the wiki).

Wiki updated

Timothy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-doc-encoders-Improve-libvo-aacenc-doc.patch
Type: application/octet-stream
Size: 1145 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130909/3f99cb14/attachment.obj>