[FFmpeg-devel] [PATCH] matroskaenc: Bump DocTypeVersion to 4

Alexander Strasser eclipse7 at gmx.net
Sat Sep 14 22:20:23 CEST 2013


Hi James,

On 2013-09-14 15:40 -0300, James Almer wrote:
> On 14/09/13 2:57 PM, Alexander Strasser wrote:
> > On 2013-09-14 01:56 -0300, James Almer wrote:
> >> The muxer has been creating files with v4 elements for some time now,
> >> and especially now that we can mux non-experimental Opus files, reporting
> >> the DocTypeVersion as 2 is not correct.
> >>
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >>  libavformat/matroskaenc.c | 2 +-
> >>  tests/ref/lavf/mkv        | 4 ++--
> >>  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> >   Not necessarily related to this patch:
> > 
> >   Do we need to care about DocTypeReadVersion too, or are all produced
> > files fine for playback by players that only support version 2. I would
> > think so, but I did not investigate. E.g. in the case of Opus, will it
> > play (with problems) or not at all.
> 
> I didn't touch DocTypeReadVersion because not even mkvtoolnix seems to set 
> it at anything but two.
> 
> Unless the spec at some point states that some v4 elements are a must for 
> a given scenario (i don't think it currently does), i don't think setting 
> the DocTypeReadVersion to 4 will be a good idea, considering that's what 
> every demuxer out there checks to make sure they can read the file.

  Should all be fine according to Hendrik.

  So yes, I agree DocTypeReadVersion should stay at 2.

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130914/afd784ac/attachment.asc>


More information about the ffmpeg-devel mailing list