[FFmpeg-devel] [PATCH] avfilter: avoid testing float == 0

Michael Niedermayer michaelni at gmx.at
Sun Sep 15 15:40:45 CEST 2013


On Thu, May 09, 2013 at 04:56:39PM +0200, Michael Niedermayer wrote:
> This fixes the hypothetical case of rounding errors causing
> incorrect values to be used.
> 
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavfilter/avfilter.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
> index 3f94dde..6c3cb05 100644
> --- a/libavfilter/avfilter.c
> +++ b/libavfilter/avfilter.c
> @@ -994,7 +994,7 @@ static int ff_filter_frame_framed(AVFilterLink *link, AVFrame *frame)
>          dstctx->var_values[VAR_T] = pts == AV_NOPTS_VALUE ? NAN : pts * av_q2d(link->time_base);
>          dstctx->var_values[VAR_POS] = pos == -1 ? NAN : pos;
>  
> -        dstctx->is_disabled = !av_expr_eval(dstctx->enable, dstctx->var_values, NULL);
> +        dstctx->is_disabled = fabs( av_expr_eval(dstctx->enable, dstctx->var_values, NULL) ) < 0.5;
>          if (dstctx->is_disabled)
>              filter_frame = dst->passthrough_filter_frame ? dst->passthrough_filter_frame
>                                                           : default_filter_frame;

spaces fixed
patch approved by nevcairiel on IRC
commit message made more verbose

patch applied

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130915/314ffa9f/attachment.asc>


More information about the ffmpeg-devel mailing list