[FFmpeg-devel] [PATCH] avfilter: port pullup filter from libmpcodecs

Carl Eugen Hoyos cehoyos at ag.or.at
Wed Sep 18 10:06:32 CEST 2013


Paul B Mahol <onemda <at> gmail.com> writes:

> On the serious side, if there are issues remaining, 
> visit trac.ffmpeg.org

Sure, but don't you agree that these are issues that should 
either be addressed before commit or at least agreed that 
they (for whatever reason) cannot be fixed atm?
I agree both that this is an important feature and that it 
is very helpful that you have ported it but now we have a 
memleak, invalid memory access (did anyone already test on 
Windows?) and I don't think a user can guess how to 
actually use the filter (this is not much different from 
fieldmatch but this is "no excuse" iiuc) because you did 
not want to spend the additional hour on it.
(I have no idea why one frame is still around after eof 
but I would expect you to know soon.)

And it not 100% clear why the valgrind output on trac 
would help but does not help on the mailing list.

Sorry, Carl Eugen



More information about the ffmpeg-devel mailing list