[FFmpeg-devel] [PATCH] lavf/matroska: Export codecdelay and seekpreroll as metadata tags

[Vignesh Venkatasubramanian]

On Wed, Sep 18, 2013 at 11:39 AM, wm4 <nfxjfg at googlemail.com> wrote:
> On Tue, 17 Sep 2013 12:36:47 -0700
> Vignesh Venkatasubramanian <vigneshv at google.com> wrote:
>
>> This patch exports the values of Codec Delay and Seek Preroll
>> container elements as metadata tags.
>
> Shouldn't metadata contain tags? How do I know whether a metadata entry
> should be user-visible (because it's a tag) or not (because it's file
> specific data).
>
> Is this information needed for correct playback (i.e. does a video
> player need it)? If yes, shouldn't it be part of the AVCodecContext? If
> no, why export it?

Agreed. Lack of understanding from my part caused this confustion. Sorry
about that.

Anyway, I think it should be part of AVStream and not AVCodecContext.
Is that correct? I will update the patch accordingly.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel