[FFmpeg-devel] [PATCH] Native VP9 decoder.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Sep 21 20:19:32 CEST 2013


On Sat, Sep 21, 2013 at 08:53:09AM -0400, Ronald S. Bultje wrote:
> +    enum FilterMode filtermode:3;

I don't think enum bitfields are actually valid C?
Also, is there a specific reason to use bitfields at all?
It seems like it won't save all that much, and is one of the
less reliable things in C compilers in my experience,
and I believe at least compiling for ARM used to produce
code with atrocious performance for it (I think basically
it ended up doing a manual unaligned load of the unsigned).
No, I am not asking you to change it, but I sure would
be interested in the reasoning, to me it is still a
"better save yourself the pain" feature.


More information about the ffmpeg-devel mailing list