[FFmpeg-devel] Patch (2/2) Make MPEGTSENC understand Teletext Encoding Language String

[Clément Bœsch]

On Mon, Sep 23, 2013 at 01:35:03PM +0100, JULIAN GARDNER wrote:
[...]
> > Note: your coding style is completely off in that patch as well.
> > 
> 
> what am i missing, coding style wise? some clues please

See http://ffmpeg.org/developer.html#Coding-Rules-1

some examples with your code:

> >>  +                    sscanf( language, "%x", &page);
                                 ^^^

> >>  +                    if( page>0x7ff)
                           if (page > 0x7ff)

> >>  +                    if (*language!=',')
                           if (*language != ',')

etc.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130923/2066fc18/attachment.asc>