[FFmpeg-devel] [PATCH 2/3] configure: check and use -Werror=empty-body

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Apr 4 07:26:59 CEST 2014


On 04.04.2014, at 00:57, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Apr 04, 2014 at 12:53:55AM +0200, James Darnley wrote:
>> On 2014-04-04 00:45, James Darnley wrote:
>>> Would have caught the trailing semi-colon in lavu/log.c that broke detection of
>>> 256 colour capable terminals.
>>> ---
>>> configure |    1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>> 
>>> diff --git a/configure b/configure
>>> index 46452ee..cb76890 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -4776,6 +4776,7 @@ check_cflags -Wundef
>>> check_cflags -Wmissing-prototypes
>>> check_cflags -Wno-pointer-to-int-cast
>>> check_cflags -Wstrict-prototypes
>>> +check_cflags -Werror=empty-body
>>> enabled extra_warnings && check_cflags -Winline
>>> 
>>> check_disable_warning(){
>>> 
>> 
>> Is it ever not an error?
> 
> it could be if the body disappears due to a macro

Isn't that kind of dangerous and shouldn't the macros rather replace with do { } while (0)?
Though I guess the compiler might consider that an empty body as well?


More information about the ffmpeg-devel mailing list