[FFmpeg-devel] [PATCH] lavu/opt: validate range before dereference

Lukasz Marek lukasz.m.luki2 at gmail.com
Fri Apr 4 19:28:45 CEST 2014


From: Lukasz Marek <lukasz.m.luki at gmail.com>

This change make error handling simplier.
av_opt_freep_ranges may be called when some ranges are NULL,
for example after memory allocation fail.

Signed-off-by: Lukasz Marek <lukasz.m.luki at gmail.com>
---
 libavutil/opt.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavutil/opt.c b/libavutil/opt.c
index ea2a5b7..33ebe52 100644
--- a/libavutil/opt.c
+++ b/libavutil/opt.c
@@ -1613,8 +1613,10 @@ void av_opt_freep_ranges(AVOptionRanges **rangesp)
 
     for (i = 0; i < ranges->nb_ranges * ranges->nb_components; i++) {
         AVOptionRange *range = ranges->range[i];
-        av_freep(&range->str);
-        av_freep(&ranges->range[i]);
+        if (range) {
+            av_freep(&range->str);
+            av_freep(&ranges->range[i]);
+        }
     }
     av_freep(&ranges->range);
     av_freep(rangesp);
-- 
1.7.10.4



More information about the ffmpeg-devel mailing list