[FFmpeg-devel] Patch: Inline asm fixes for Intel compiler on Windows

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Apr 5 15:03:47 CEST 2014


On Sat, Apr 05, 2014 at 11:52:59PM +1100, Matt Oliver wrote:
> >
> > declaration after statement
> 
> 
> Sorry, fixed in new patch.

If you do not initialize "bit", making it an output-only paramenter,
you should use =&q instead of +q as constraint.
However neither is correct as-is, setae sets only a single byte,
thus not initializing it will result in uninitialized data,
IOW the code as is is broken.
If you want to do that kind of change, you would have to use uint8_t
instead as type.


More information about the ffmpeg-devel mailing list