[FFmpeg-devel] [PATCH 2/5] lavf/concatdec: check match_streams() return value.

Michael Niedermayer michaelni at gmx.at
Fri Apr 25 16:43:50 CEST 2014


On Fri, Apr 25, 2014 at 10:40:59AM +0200, Nicolas George wrote:
> Le tridi 3 floréal, an CCXXII, Michael Niedermayer a écrit :
> > LGTM, but you are the author so you should know all this better
> > than me. In that same sense IMO the whole patchset is ok
> 
> Thanks. For files that I authored or maintain, I send patches so that people
> have a little time to see what is coming (including conflicts with their own
> work-in-progress), to spot obvious mistakes, to suggest better solutions,
> etc. Only if they have time and are interested. If I see no reply, I will
> wait a few days / for the other patches to be approved and push or ask you
> to merge.
> 

> And of course, when the patch adds a user-visible feature (like 5/5 in this
> series), feedback about the feature itself is as important as feedback about
> the implementation.

the feature itself sounds nice and useful

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140425/db43b584/attachment.asc>


More information about the ffmpeg-devel mailing list