[FFmpeg-devel] [PATCH] doc/examples/muxing: make compatible with C++

[anshul]

On 04/29/2014 03:18 AM, Michael Niedermayer wrote:
> On Mon, Apr 14, 2014 at 04:51:44PM +0530, anshul wrote:
>> On 04/13/2014 11:51 AM, Anshul wrote:
>>> Michael Niedermayer <michaelni at gmx.at> wrote:
>>>> running a make distclean with this patch applied
>>>> produces:
>>>> Package libavdevice was not found in the pkg-config search path.
>>>> Perhaps you should add the directory containing `libavdevice.pc'
>>>> to the PKG_CONFIG_PATH environment variable
>>>> No package 'libavdevice' found
>>>> Package libswresample was not found in the pkg-config search path.
>>>> Perhaps you should add the directory containing `libswresample.pc'
>>>> to the PKG_CONFIG_PATH environment variable
>>>> No package 'libswresample' found
>>>> Package libavdevice was not found in the pkg-config search path.
>>>> Perhaps you should add the directory containing `libavdevice.pc'
>>>> to the PKG_CONFIG_PATH environment variable
>>>> No package 'libavdevice' found
>>>> Package libswresample was not found in the pkg-config search path.
>>>> Perhaps you should add the directory containing `libswresample.pc'
>>>> to the PKG_CONFIG_PATH environment variable
>>>> No package 'libswresample' found
>>>>
>>> I am looking at it.
>> Done.
>>>>> diff --git a/doc/Makefile b/doc/Makefile
>>>>> index 44049c4..5c1371a 100644
>>>>> --- a/doc/Makefile
>>>>> +++ b/doc/Makefile
>>>>> @@ -36,6 +36,13 @@ DOCS-$(CONFIG_MANPAGES)  += $(MANPAGES)
>>>>>   DOCS-$(CONFIG_TXTPAGES)  += $(TXTPAGES)
>>>>>   DOCS = $(DOCS-yes)
>>>>> +EXAMPLE_CPP_MAKE=make
>>>>> +EXAMPLE_CPP_MAKE_VERSION := $(shell $(EXAMPLE_CPP_MAKE) --version 2>
>>>> /dev/null )
>>>>> +ifndef EXAMPLE_CPP_MAKE_VERSION
>>>>> +EXAMPLE_CPP_MAKE=gmake
>>>>> +EXAMPLE_CPP_MAKE_VERSION := $(shell $(EXAMPLE_CPP_MAKE) --version 2>
>>>> /dev/null )
>>>>> +endif
>>>> that looks really wrong
>>>> a Makefile should not need to test for how the make application is
>>>> called
>>>>
>>>>
>>>> [...]
>>> This was done since you said make is not available on openBSD.
>>> I choose to call makefile, since I cant compile the code with existing makefile the default behavior of checking compiler for cpp has been changed in existing makefile.
>>>
>>> I am open for suggestions what should be done else.
>>>
>>>
>> I got , There is another way, i have used $(MAKE) now.
>> here is the link i followed
>> <http://www.gnu.org/software/make/manual/make.html#MAKE-Variable>
>> Thanks for hint
> if i run make distclean with this patch applied i get
>
> make distclean
> make -C doc/examples_cpp/ clean
> make[1]: Entering directory `ffmpeg/doc/examples_cpp'
> rm -f test*.pgm test.h264 test.mp2 test.sw test.mpg
> rm -f avio_reading avcodec demuxing_decoding filtering_video filtering_audio metadata muxing remuxing resampling_audio scaling_video transcode_aac transcoding  avio_reading.o avcodec.o demuxing_decoding.o filtering_video.o filtering_audio.o metadata.o muxing.o remuxing.o resampling_audio.o scaling_video.o transcode_aac.o transcoding.o
> make[1]: Leaving directory `ffmpeg/doc/examples_cpp
>
> Why does this show examples_cpp but not examples, why is it different?
>
> [...]
>
>
C examples are using doc/Makefile not the doc/example/Makefile
for c language all the option and  setting which are used for ffmpeg 
would work,
but for C++ language options for ffmpeg does not work. therefore using 
doc/Makefile
would not be feasible.


Thanks
Anshul Maheshwari