[FFmpeg-devel] [PATCH 1/4] lavfi: add filter metaframes infrastructure.

Nicolas George george at nsup.org
Sun Aug 3 15:19:06 CEST 2014


Le quintidi 15 thermidor, an CCXXII, Stefano Sabatini a écrit :
> It shall probably execute the remaining part of the function even in
> case of failure.

I am not completely sure about that. AFAIK, we consider most filtering
failures fatal at some point or another anyway.

> I find this a bit confusing. Can you explain why the NOP metaframe is
> needed?

Depending on the type of the message and the default action taken, filters
may need to inhibit the default action because they already did the work or
changed something else somewhere that would conflict. I can remove that hunk
and wait for something to actually use it if you prefer.

> LGTM otherwise.

Thanks to everyone for the reviews. New series posted.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140803/7a11be2d/attachment.asc>


More information about the ffmpeg-devel mailing list