[FFmpeg-devel] [PATCH 1/2] avutil/libm: Replace macro based fminf() by function

wm4 nfxjfg at googlemail.com
Mon Aug 4 21:39:55 CEST 2014


On Mon, 04 Aug 2014 21:25:12 +0200
Bernd Kuhls <bernd.kuhls at t-online.de> wrote:

> Michael Niedermayer <michaelni at gmx.at> wrote in news:1402065736-24164-1-git-
> send-email-michaelni at gmx.at:
> 
> >  libavutil/libm.h |    5 ++++-
> 
> Hi,
> 
> the current code in libm.h breaks compilation when the libc does not provide 
> fminf, which is the case for uClibc. Here you will find a patch fixing the 
> problem for me, although the problem should maybe be fixed in a different 
> way:
> 
> http://git.buildroot.net/buildroot/tree/package/ffmpeg/ffmpeg-0001-
> fminf.patch
> 
> For background discussion please look here:
> http://thread.gmane.org/gmane.comp.lib.uclibc.buildroot/90973/focus=90994
> 
> Regards, Bernd

the problem is obviously that uclibc provides a fminf prorotype, but no
implementation. Obviously this breaks any application that attempts to
detect fminf, and provides its own fallback if it doesn't appear to
exist.

Why do you think ffmpeg should be patched for this, and not uclibc?


More information about the ffmpeg-devel mailing list