[FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: check RDFT contet init.

[Clément Bœsch]

On Sun, Aug 03, 2014 at 08:40:36PM +0200, Nicolas George wrote:
> Fix a segfault with large window size.
> 
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  libavfilter/avf_showspectrum.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c
> index 7bf3aab..764a000 100644
> --- a/libavfilter/avf_showspectrum.c
> +++ b/libavfilter/avf_showspectrum.c
> @@ -177,6 +177,11 @@ static int config_output(AVFilterLink *outlink)
>  
>          av_rdft_end(s->rdft);
>          s->rdft = av_rdft_init(rdft_bits, DFT_R2C);
> +        if (!s->rdft) {
> +            av_log(ctx, AV_LOG_ERROR, "Unable to allocate RDFT context. "

s/allocate/create/

> +                   "Maybe window too high.\n");

"The window height might be too high."

> +            return AVERROR(EINVAL);
> +        }

LGTM otherwise

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140806/c81e2836/attachment.asc>