[FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

Clément Bœsch u at pkh.me
Thu Aug 14 20:00:21 CEST 2014

On Thu, Aug 14, 2014 at 05:37:25PM +0000, Carl Eugen Hoyos wrote:
> Clément Bœsch <u <at> pkh.me> writes:
> > Carl, do you want the fallback to work just when 
> > pkg-config is not available
> I believe this would still leave some use-cases 
> unsolved.
> > or do you actually want a real fallback when it is 
> > present but didn't succeed?
> This is the preferred solution imo.
> > (the second solution is way uglier to solve)
> You had already sent a patch iirc.

No it won't work because require_pkg_config dies if it fails, so you can
fallback after it.

Of course we can add another require_pkg_config2() that takes some
explicit linking flags in addition to the user ones as a fallback. But
really that's insane, because I know you will end-up hardcoding all kind
of linker flags to these fallback calls, and this defeat completely the
purpose of such simplified code. They will also almost never be tested,
and will be incorrect almost every single time. I don't want that, and I'd
prefer if we error out properly saying something as obvious as "libXXX
detection needs pkg-config, please get install it and retry" + some
documentation (doc/*texi and ./configure --help).

Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140814/9019f317/attachment.asc>

More information about the ffmpeg-devel mailing list