[FFmpeg-devel] [PATCH 2/4] wavpackenc: make assert more thorough

Christophe Gisquet christophe.gisquet at gmail.com
Fri Aug 22 11:31:43 CEST 2014


It was only validating that normal data wasn't filling the buffer.
However, extra data may be written afterwards.
---
 libavcodec/wavpackenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c
index 169836a..299a035 100644
--- a/libavcodec/wavpackenc.c
+++ b/libavcodec/wavpackenc.c
@@ -2813,7 +2813,7 @@ static int wavpack_encode_block(WavPackEncodeContext *s,
     block_size = bytestream2_tell_p(&pb);
     AV_WL32(out + 4, block_size - 8);
 
-    av_assert0(put_bits_left(&s->pb) > 0);
+    av_assert0(!bytestream2_get_eof(&pb));
 
     return block_size;
 }
-- 
1.9.2.msysgit.0



More information about the ffmpeg-devel mailing list