[FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

[Andreas Cadhalpun]

On 26.08.2014 14:39, Michael Niedermayer wrote:
> On Tue, Aug 26, 2014 at 02:32:00PM +0200, Clément Bœsch wrote:
>> On Tue, Aug 26, 2014 at 02:27:45PM +0200, Michael Niedermayer wrote:
>>> On Tue, Aug 26, 2014 at 02:22:08PM +0200, Andreas Cadhalpun wrote:
>>>> On 26.08.2014 14:11, Clément Bœsch wrote:
>>>>> On Tue, Aug 26, 2014 at 01:52:19PM +0200, Michael Niedermayer wrote:
>>>>> [...]
>>>>>>> I'm fine with the patch, even though Lena has a special meaning in video
>>>>>>> processing...
>>>>>>
>>>>>> yep, i wonder if this is the best solution after sleepng over it.
>>>>>> the lena image is well known, also people know how girls look,
>>>>>> people will recognize artiacts easily in it.
>>>>>> Noone would easily notice if a flower has a different color tone or
>>>>>> some spots. So it may be better to actually try to keep using lena
>>>>>>
>>>>>
>>>>> Yes. Also, the picture is really under fair use in FFmpeg…
>>>>>
>>>>> See also https://en.wikipedia.org/wiki/File:Lenna.png#Fair_use_for_Playboy
>>>>
>>>> Yes, it falls under fair use for FFmpeg. But Debian only accepts
>>>> files with a DFSG-free license [1], which lena.pnm lacks.
>>>>
>>>
>>>>>> In that light ive posted a naive patch that just downloads lena.pnm
>>>>>> if its missing, a 3rd alternative to that would be to move it to the
>>>>>> fate suite as andreas initially suggested.
>>>>>
>>>>> It's really insane to wget this in a code that worked without access to
>>>>> the net. The wget is unexpected here. Also, this is probably not going to
>>>>> help for the package since the goal is to run the tests depending on the
>>>>> picture.
>>>>
>>>> Downloading lena.pnm won't work for example on Debian's build
>>>> daemons, which don't allow access to the internet during package
>>>> build.
>>>
>>> the build daemons run make fate ?
>>> because the download should only happen when the file is needed
>>> and its only needed for the tests
>>>
>>
>> make fate works without samples.
>>
>> Also, if I'm offline and use git clean, I can't run make anymore even if i
>> still have the samples in a dedicated directory.
>>
>> Last, it adds a wget dependency.
>
> the idea was to add the download rule to the makefile as in the
> patch but leave lena.pnm in git.
> That way debian could simply drop the file and still have working
> make test (when there is net access)

That would be bad, because it would work, when I test it (with internet 
access), but then fail on the build daemons.
Also it's better not having to repack, because then anyone can verify 
that the Debian tarball matches the signatures for the original one.

> either way, i suggest that until we have a consensus, andreas
> should probably pick any of the solutions for debian so theres
> no delay on the debian side

I would prefer having a solution applied in ffmpeg.git first.

If the lena.pnm image is considered better for testing, then it should 
be added to the fate samples for download, which are anyway used by most 
developers. As long as it is not in the distributed tarball it is no 
problem.

If having an example image in the tarball is important, the flower.pnm 
(or any other free image) can be added, even if no test needs it.

Best regards,
Andreas