[FFmpeg-devel] [FFmpeg-cvslog] avformat/rtpdec_asf: fix compiler warning about const qualifier being discarded

Michael Niedermayer michaelni at gmx.at
Thu Aug 28 04:28:55 CEST 2014


On Wed, Aug 27, 2014 at 06:17:36PM -0700, Timothy Gu wrote:
> Michael Niedermayer <git at videolan.org> writes:
> 
> >
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Wed Aug 27 23:53:53 2014 +0200|
> > [e6516944a3d504f208911033b31afedb3d427267] | committer: Michael Niedermayer
> >
> > avformat/rtpdec_asf: fix compiler warning about const qualifier being
> > discarded
> >
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=e6516944a3d504f208911033b31afedb3d427267
> > ---
> >
> >  libavformat/rtpdec_asf.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/rtpdec_asf.c b/libavformat/rtpdec_asf.c
> > index 541b86f..8e19654 100644
> > --- a/libavformat/rtpdec_asf.c
> > +++ b/libavformat/rtpdec_asf.c
> >  @@ -188,7 +188,7@@ static int asfrtp_parse_packet(AVFormatContext *s,
> > PayloadContext *asf,
> >
> >          av_freep(&asf->buf);
> >
> 
> > -        ffio_init_context(pb, buf, len, 0, NULL, NULL, NULL, NULL);
> > +        ffio_init_context(pb, (uint8_t *)buf, len, 0, NULL, NULL, NULL,
> > NULL);
> 
> Wouldn't it be more correct to declare ffio_init_context's second
> argument const?

ffio_init_context() can also be used for writing


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140828/7993ae37/attachment.asc>


More information about the ffmpeg-devel mailing list