[FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

[wm4]

On Sun, 31 Aug 2014 15:06:08 +0000 (UTC)
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> wm4 <nfxjfg <at> googlemail.com> writes:
> 
> > > > +    return AVPROBE_SCORE_EXTENSION;
> > > 
> > > I understand if you consider it not worth the effort,
> > > but ideally this would scan ahead several packets,
> > > and if it all matches up return a higher score.
> > > The MP3 probe function is possibly a good reference 
> > > (though this one should be bit simpler).
> 
> I have written such a patch some time ago, so you can 
> commit with AVPROBE_SCORE_EXTENSION / 2 (or / 4), I 
> will try to improve using my older work if you want.
> (It was too slow so it has to be changed.)

That would potentially be helpful, but I think I can
finish this patch without it.

> > Other formats are also relatively lazy
> 
> Please point me to such a format, I would like to 
> fix it.
> EXTENSION is ok for 32 bit, MAX is ok for 64bit.
> I think there is one bad example, but I cannot 
> find it atm.

E.g pictor_probe in img2dec.c. Though that returns
AVPROBE_SCORE_EXTENSION / 4, which is certainly low
enough (it's <= AVPROBE_SCORE_RETRY, so the API user
knows that it's unreliable).