[FFmpeg-devel] fix for decklink_common.cpp
jonbae77 at gmail.com
Tue Dec 2 17:00:43 CET 2014
that means that the patch is at the moment not useful?! This code comes
from the decklink sdk and there was also the FAILED() defined, I think. I
have the code from here:
and there they say it works.
When is ok for you, I copy your answer to the zeranoe forum, then they can
help me to fix it.
2014-12-02 16:45 GMT+01:00 Carl Eugen Hoyos <cehoyos at ag.or.at>:
> Jon bae <jonbae77 <at> gmail.com> writes:
> > I hope is all right, I never did before a
> > git format-patch...
> You used git format-patch perfectly, thank you.
> Your patch introduces tabs, they cannot be committed
> to FFmpeg. You can find tabs with "tools/patcheck",
> a script that is part of the source.
> Please do not replace av_log() with fprintf().
> Please do not move opening braces, just leave them
> where they are now.
> Please keep the indentation at four spaces.
> Assuming that the "free" fix is unrelated to the
> remaining patch, please make it separate.
> (I don't know where FAILED() is defined and
> therefore cannot comment on the actual patch and
> if it can be simplified.)
> Thank you, Carl Eugen
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel