[FFmpeg-devel] [PATCH] imc: make issue non-fatal

[Michael Niedermayer]

On Thu, Dec 04, 2014 at 12:04:50AM +0100, Christophe Gisquet wrote:
> Until a noticeably distorted output or crash is reported, it's better
> ignoring the "error", as this results in better output on the affected
> samples. (ticket #3886)
> 
> On the other hand, I have a hard time understanding the purpose of
> that check. I would have expected maybe "get_bits_count(&q->gb) <
> cw_len", but the next parsing step, inverse_quant_coeff, does not even
> check what's left.
> 
> -- 
> Christophe

>  imc.c |   15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 4334ed60bfabb1f4679940664aeece3d4274a22a  0001-imc-make-issue-non-fatal.patch
> From 90b5642bd53b24f66f1c36c070b4c490dd72a6cf Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Wed, 3 Dec 2014 23:52:52 +0100
> Subject: [PATCH] imc: make issue non-fatal
> 
> The "faulty" samples actually sound fine when ignoring this issue.
> 
> For ticket #3886, more samples are decoded.

applied

also i see at least one bug in the original code, will fix it

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141204/fc526210/attachment.asc>