[FFmpeg-devel] libavutil : cosmetic: added spaces wherever necessary

Michael Niedermayer michaelni at gmx.at
Tue Dec 16 13:35:47 CET 2014


On Tue, Dec 16, 2014 at 03:00:24PM +0530, supraja reddy wrote:
> Hi,
> 
> Attached patch adds some missing spaces in the cast5.c and cast5.h
> 
> Please let me know if any further changes needed.
[...]

> -    for (i=0;i<=cs->rounds;i++)
[...]
> +    for (i = 0; i < cs->rounds; i++)
> +        cs->Kr[i] = cs->Kr[i] & 0x1f;

this is not a cosmetic change and is not correct
Kr[cs->rounds] is used in some shifts
Kr[0] might be unused though

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141216/32dc5f01/attachment.asc>


More information about the ffmpeg-devel mailing list