[FFmpeg-devel] [PATCH]Only enable xcb-shm if error fields are available in the header

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Dec 25 18:52:36 CET 2014


Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:

> Clément Bœsch <u <at> pkh.me> writes:
> 
> > > -        check_pkg_config xcb-shm xcb/shm.h xcb_shm_attach || {
> > > +        check_pkg_config xcb-shm xcb/shm.h xcb_shm_attach &&
> > > +        check_code cc xcb/xcb.h "xcb_generic_error_t e; 
> > > e.resource_id = 0" || {
> > 
> > No, you just want something like check_pkg_config "xcb-shm >= 1.4"

Could you provide a patch that I could test?
(I don't think your idea works but since I 
don't know much about pkg-config, I may miss 
something.)

> Wouldn't this needlessly break building with xcb 1.3 installed?

Sorry, please ignore this.

Thank you, Carl Eugen



More information about the ffmpeg-devel mailing list