[FFmpeg-devel] [PATCH 07/15] vp8/x86: move variable assigned inside macro branch.

[Clément Bœsch]

On Sat, Dec 27, 2014 at 11:02:42AM -0500, Ronald S. Bultje wrote:
> The value is not used outside the branch.
> ---
>  libavcodec/x86/vp9lpf.asm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/x86/vp9lpf.asm b/libavcodec/x86/vp9lpf.asm
> index e117798..15d4159 100644
> --- a/libavcodec/x86/vp9lpf.asm
> +++ b/libavcodec/x86/vp9lpf.asm
> @@ -469,8 +469,8 @@ cglobal vp9_loop_filter_%1_%2_16, 2, 6, 16, %3 + %4, dst, stride, mstride, dst2,
>  
>      ; (m3: fm, m8..15: p3 p2 p1 p0 q0 q1 q2 q3)
>      ; calc flat8in (if not 44_16) and hev masks
> -    mova                m6, [pb_81]                     ; [1 1 1 1 ...] ^ 0x80
>  %if %2 != 44
> +    mova                m6, [pb_81]                     ; [1 1 1 1 ...] ^ 0x80
>      ABSSUB_GT           m2, m8, m11, m6, m5             ; abs(p3 - p0) <= 1
>      mova                m8, [pb_80]
>      ABSSUB_GT           m1, m9, m11, m6, m5, m8         ; abs(p2 - p0) <= 1

Should this be merged or moved just after patch 4?

LGTM

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141227/b58d9510/attachment.asc>