[FFmpeg-devel] [PATCH] x86/swr: add SSE2/AVX pack_8ch functions

[Michael Niedermayer]

On Tue, Dec 30, 2014 at 09:58:24PM -0300, James Almer wrote:
> On 30/12/14 7:57 PM, Michael Niedermayer wrote:
> > On Tue, Dec 30, 2014 at 06:20:15PM -0300, James Almer wrote:
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >>  libavcodec/x86/flacdsp.asm             |  13 ---
> >>  libavutil/x86/x86util.asm              |  37 +++++++++
> >>  libswresample/x86/audio_convert.asm    | 145 +++++++++++++++++++++++++++++++++
> >>  libswresample/x86/audio_convert_init.c |  17 ++++
> >>  4 files changed, 199 insertions(+), 13 deletions(-)
> > 
> > looks ok from a quick look and fate passes on linux & mingw 32&64
> 
> Does any fate test deal with 8ch fltp/s32p -> flt/s32 conversion? I don't think I've 
> seen anything beyond 6ch.

i dont know but if not a fate test should be added ideally


> 
> I'll wait a bit to see if i can get a more thorough review before pushing. I'm mainly 
> interested in having the non-transpose-related 32bits stack usage looked at.

sure

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141231/c43d5088/attachment.asc>