[FFmpeg-devel] [PATCH] RoQ-encoder: introducing Quake 3 compatibility option

u-owvm at aetey.se u-owvm at aetey.se
Sat Feb 1 17:57:14 CET 2014


Hello Clément,

On Sat, Feb 01, 2014 at 05:01:44PM +0100, Clément Bœsch wrote:
> > +    { "quake3_compat", "Whether to respect known bugs in Quake 3 decoder", OFFSET(quake3_compat), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, VE },
> 
> Just curious; isn't ioquake3 opensource? Can't you submit a bugfix there
> instead?

Answering the second part of your question
(the first one was rhetorical, wasn't it?)

The wording of the Subject can be possibly misleading.

The patch does not introduce compatibility, it introduces the option to
switch _off_ the compatibility. The compatibility was otherwise already
present before, hardcoded, without any option to get rid of it.

My point was to make ffmpeg's encoder more usable for _other_ purposes
than together with a certain decoder. Bugfixing ioquake3 is offtopic
for me and I guess for this list too.

> Otherwise, if it's a feature limitation, the description shouldn't mention
> "bugs".

No problem, be it a feature or bug, let this sound
    "Whether to respect known limitations in Quake 3 decoder"
which looks nicer indeed.

Hope the person (if any) applying the patch can make this change
 s/known bugs/known limitations/

Regards,
Rl



More information about the ffmpeg-devel mailing list