[FFmpeg-devel] [PATCH] ffmpeg: add otsoffset option

[Stefano Sabatini]

On date Friday 2014-01-31 01:13:40 +0100, Stefano Sabatini encoded:
> On date Tuesday 2014-01-28 17:19:34 +0100, Michael Niedermayer encoded:
> > On Tue, Jan 28, 2014 at 01:33:42AM +0100, Stefano Sabatini wrote:
> > > On date Tuesday 2014-01-28 01:24:34 +0100, Michael Niedermayer encoded:
> > > > On Mon, Jan 27, 2014 at 07:53:33PM +0100, Stefano Sabatini wrote:
> [...]
> > > > > Note: I'm not sure about the av_format_get_output_ts_offset()
> > > > > accessors, should I keep them or let the user set them via the
> > > > > AVOption API?
> > > > 
> > > > whichever you prefer
> > > 
> > > I don't want to add an API which is not strictly required (and the
> > 
> > agree
> > 
> > > other AVFormatContext accessors seem to be used only for setting
> > > binary content), but I'm not sure about that.
> > 
> 
> > the accessors make most sense for things that need to be accessed
> > often as AVOptions currently have to do string matching to find a
> > entry and that isnt the fastest way to access things.
> 
> Yes, although this is probably not the case.
> 
> > Also the accessors might be felt to be prettier when used from C code
> > to set / get fields than using a API thats based on a string representing
> > the field to be set ("otsoffset")
> 
> Then we should probably add av_opt_set/get_duration().
> 
> I'll remove the accessors and will push the patch, set/get_duration()
> belongs to another patch.

Applied.
-- 
FFmpeg = Faithless Freak Minimalistic Pacific Experimenting Governor