[FFmpeg-devel] Patch: icl linker errors in cmdutils

[Carl Eugen Hoyos]

Matt Oliver <protogonoi <at> gmail.com> writes:

> If this patch had instead been submitted as "Optimize by
> removing unnecessary if(0)/if(1) in cmdutils" would it 
> have been more likely to have been accepted.

Optimization patches need benchmarks.

> Relying on a compiler to remove unneeded code
> is generally not a good idea

FFmpeg relies on dead-code-elimination on many, many 
places in the source, even compilers that fail FFmpeg 
compilation succeed with dead-code elimination.

Are you using FFmpeg's configure script?
If yes, how does your configure line looks like?

Carl Eugen