[FFmpeg-devel] [PATCH] ffmpeg: make reading packets from thread blocking.

Nicolas George george at nsup.org
Thu Feb 20 11:31:23 CET 2014


Le duodi 2 ventôse, an CCXXII, Michael Niedermayer a écrit :
> iam not sure, do we have more places where this would be needed?

There are a few places that toy with pthread conditions on their own, they
probably would benefit from a well-tested implementation.

Also, for code that do not exist yet but will at some point, there are the
devices with windows: they will need a thread to handle things like refresh
events, and messages to notify of user interaction.

> LGTM

Thanks. Then please pull from my tree:

299a568 ffmpeg: make reading packets from thread blocking.


Clément:

> I wonder if that fix will appease helgrind FATE instance, which is
> complaining about that finished variable on virtually every test with
> threading.

Unfortunately not yet: these warnings are about the transcoding_finished
global condition. A clean implementation of messages queue would avoid that
kind of global, though.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140220/c5312c10/attachment.asc>


More information about the ffmpeg-devel mailing list