[FFmpeg-devel] [PATCH] lavu/buffer: add release function

Lukasz Marek lukasz.m.luki at gmail.com
Tue Feb 25 02:15:19 CET 2014


>> If so then OK, just haven't found it in docs (I did not read all tho)
>
> i dont know if its documented.

I will put it then on my TODO, but it may take some time to back to it :)

>>> do you know of a case where this needs to be atomic ?
>>
>> OK, but why it is used in other places? If no use case in here than
>> what's the use case in av_buffer_is_writable for example?
>
>> If you are
>> sure it is not required then feel free to ignore this patch.
>> Probably OK, I haven't investigate it before, just guessed from
>> other uses of this function.
>
> Iam not sure, which is why i asked
> and also why ive not suggested to remove it from
> av_buffer_is_writable()
> I dont immedeatly see why it would be needed, this does not mean its
> not needed
> but i would suggest to leave it on all functions that are not speed
> critical

I checked it in git history and your patch was commented as helpful for 
debugging so it is also not speed critical :) TBH I don't feel competent 
in this area, but I will ask a friend about it tomorrow, and hopely some 
one else will read this thread too. It can wait anyway.
Thanks for comments.

-- 
Best Regards,
Lukasz Marek

Royale with Cheese.


More information about the ffmpeg-devel mailing list