[FFmpeg-devel] [PATCH]Read bits_per_coded_sample from mkv files

Michael Niedermayer michaelni at gmx.at
Tue Feb 25 11:43:11 CET 2014


On Tue, Feb 25, 2014 at 12:12:10AM +0000, Carl Eugen Hoyos wrote:
> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> 
> > +        unsigned bit_depth;
> 
> locally changed to:
> unsigned bit_depth = 0;

i suggest you only set bits_per_coded_sample when its stored in
the bitstream and not force it to 0

> 
> (Why didn't the compiler output a warning?)

because the compiler is dumb


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140225/740c8eb0/attachment.asc>


More information about the ffmpeg-devel mailing list