[FFmpeg-devel] [PATCH]Read bits_per_coded_sample from mkv files

[Michael Niedermayer]

On Tue, Feb 25, 2014 at 01:37:12PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > On Tue, Feb 25, 2014 at 12:12:10AM +0000, Carl Eugen Hoyos wrote:
> > > Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> > > 
> > > > +        unsigned bit_depth;
> > > 
> > > locally changed to:
> > > unsigned bit_depth = 0;
> > 
> > i suggest you only set bits_per_coded_sample when its stored in
> > the bitstream and not force it to 0
> 
> Do you mean I should initialize the variable to -1 and 
> set bits_per_coded_sample to 0 if that's what's written 
> in the bitstream

yes, only set it when its read from the bitstream


> or only set bits_per_coded_sample if
> bit_depth > 0?
> 
> Carl Eugen
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140225/5601c976/attachment.asc>