[FFmpeg-devel] [FFmpeg-user] BUG in use of extradata and extradata_size with dvb subtitles and teletext

[Andriy Lysnevych]

Hi,

Here are two patches that fix DVB teletext and DVB subtitles copy issues:

First apply 0001-Fix-dvbsubtitle.patch then 0001-Fix-dvbteletext.patch

Please review those patches.

0001-Fix-dvbsubtitle.patch is the same as in
http://ffmpeg.org/pipermail/ffmpeg-devel/2014-January/152957.html thread
and discussed there. It breaks compatibility so waiting for your comments.

0001-Fix-dvbteletext.patch is new one. It does not breaks compatibility and
fixes the following issues:

1) Use extradata to copy values from PMT from input TS stream (demuxer) to
output TS stream (muxer). It is implemented in the same way as in DVB
subtitles functionality.
2) Fixes PES_header_data_length to be always 0x24 for teletext, according
to DVB standard.
3) Support of multiple languages in one DVB teletext stream.

With both patches applied DVB subtitle and teletext copy works for us.

Regards,
Andriy Lysnevych



On Wed, Jan 8, 2014 at 12:41 PM, JULIAN GARDNER <joolzg at btinternet.com>wrote:

>
>
>
>
>
>
>
> >________________________________
> > From: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> >To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> >Sent: Wednesday, 1 January 2014, 0:14
> >Subject: Re: [FFmpeg-devel] [FFmpeg-user] BUG in use of extradata and
> extradata_size with dvb subtitles and teletext
> >
> >
> >On Wed, Jan 01, 2014 at 01:12:17AM +0100, Reimar Döffinger wrote:
> >> On Mon, Dec 30, 2013 at 11:44:16AM +0200, Andriy Lysnevych wrote:
> >> > Hi,
> >> >
> >> > We are almost done with patch that fixes DVB subtitles and teletext
> issues.
> >> >
> >> > We are doing 2 things in this patch:
> >> >
> >> > 1) Removing dependency on extradata. All the values that currently
> stored
> >> > in extradatata will be generated from metadata. For example in case
> of DVB
> >> > subtitles metadata will hold the following values:
> >> >
> >> > language
> >> > subtitling_type
> >> > composition_page_id
> >> > ancillary_page_id
> >> >
> >> > This values will be used for correct PMT generation. The values can be
> >> > comma separated because one DVB subtitle stream can carry few subtitle
> >> > substreams of different language, type, etc.
> >>
> >> Sorry, but metadata is still unacceptable for this.
> >> You could change extradata to be in some textual format, but even that
> >> is questionable.
> >> If you want to specify _options_ to the muxer you should use the
> >> _option_ support, not pass options as metadata, which they clearly are
> >> not.
> >
> >Yeah, and I seem to be reading emails in backwards order, so that might
> >explain why it is a bit strange.
> >Either way, the point is I am quite sure there's ways to do whatever you
> >want to achieve that are less problematic than using metadata...
> >_______________________________________________
> >ffmpeg-devel mailing list
> >ffmpeg-devel at ffmpeg.org
> >http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
>
>
> So has anything been decided?
>
> I would like the pes fixes added if possible but we still have the problem
> of the getting the correct ids from the source to the destination subtitles
> when in copy mode, as the use of the metadata has seemingly been ruled out,
> what other way apart from fixing the new_subtitle function is there.
>
> joolz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-dvbsubtitle.patch
Type: text/x-patch
Size: 4069 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140109/ae61f489/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-dvbteletext.patch
Type: text/x-patch
Size: 7405 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140109/ae61f489/attachment-0001.bin>