[FFmpeg-devel] [RFC/PATCH]Support signed j2k images via libopenjpeg
Carl Eugen Hoyos
cehoyos at ag.or.at
Fri Jan 10 14:12:48 CET 2014
Michael Bradshaw <mjbshaw <at> gmail.com> writes:
> > - *img_ptr++ = image->comps[c].data[index] << adjust[c];
> > + *img_ptr++ = 0x8000 * image->comps[c].sgnd +
> > (image->comps[c].data[index] << adjust[c]);
> I propose casting
> image->comps[c].data[index] to unsigned int, unless
> anyone has a better suggestion.
I sent a patch, don't know if that's what you meant.
> > - *img_ptr = (uint8_t) *comp_data;
> > + *img_ptr = 0x80 * image->comps[index].sgnd
> > + (uint8_t) *comp_data;
> I'd personally get rid of this (uint8_t) cast, while you're at it.
> Otherwise, LGTM
Merged by Michael.
Thank you, Carl Eugen
More information about the ffmpeg-devel