[FFmpeg-devel] [PATCH] Properly handle cookies that specify sub-domain where the URL.

Eli Kara eli at algotec.co.il
Wed Jan 22 15:36:16 CET 2014

>> Yes, you could write:
>> Int leading_dot = (param[7] == '.');
>> But technically, the result of the expression is a boolean, not an 
>> int.

> While I don't remember the C boolean type, I just wanted to note that the variable is only used once and therefore probably unneeded.

> Please remove the tabs and consider to shorten the comment lines.

You don't remember it because it doesn't exist (smiles). I did check the C standard and it clearly states that relational operators return 1 or 0 with type int,
so my comment is relevant to C++ only, sorry about that.

I still think it is clearer with the leading_dot variable. You could place the statement inside the call to av_strdup but that would look unintelligible IMO.
The other alternative would be another if or conditional statement.

I'll wait a while longer to see if anyone else has any comments on this..

ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org

More information about the ffmpeg-devel mailing list