[FFmpeg-devel] BUG in use of extradata and extradata_size with dvb subtitles and teletext

Marton Balint cus at passwd.hu
Sat Jan 25 19:19:04 CET 2014

On Sat, 25 Jan 2014, Andriy Lysnevych wrote:

> Hi,
> Can you please review and share your thoughts about next DVB subtitles
> functionality patch. It does few thing:
> 1) Adds support of multiple languages in one DVB subtitles stream in
> the same way as it is for DVB teletext. Unfortunately this is only in
> theory because I have no such stream to test.
> 2) Unlike current implementation that always sets subtitling type to
> 0x10 (in muxer) this implementation copies subtitling type from input
> stream. In current implementation hearing impaired stream become
> normal after copying that is not fully correct.
> 3) Correctly sets subtitling type (0x20) for hearing impaired
> subtitles if no subtitling type in extradata.
> This patch changes AVStream.extradata format of DVB subtitle streams
> in MPEG-TS muxer and demuxer.

In your patch there are some completely unrelated changes to the teletext 
code as well, split the patch first to a teletext part and a dvbsub part 
at least.


More information about the ffmpeg-devel mailing list